feat(Makefile): allow setting dracut version via environment variables #2488
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ease packaging dracut for Debian/Ubuntu, please support setting the dracut main/full version via environment variables: ``` $ DRACUT_MAIN_VERSION=007 $ export DRACUT_FULL_VERSION=007-bond $ make dracut-version.sh $ grep VERSION dracut-version.sh DRACUT_VERSION=007-bond ``` Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
3 tasks
aafeijoo-suse
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
I'm not sure if this is the best approach, but it's better than #2450
LaszloGombos
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
I am not against this PR, but this PR does not resolve #2169 .
Right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To ease packaging dracut for Debian/Ubuntu, please support setting the dracut main/full version via environment variables:
Checklist