Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set KVERSION for running test suite #2490

Merged
merged 1 commit into from Aug 24, 2023

Conversation

bdrung
Copy link
Contributor

@bdrung bdrung commented Aug 19, 2023

Changes

Running the test suite in podman will most likely require setting KVERSION because the running Linux kernel version will most likely be different to the kernel version in the container.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Running the test suite in podman will most likely require setting
`KVERSION` because the running Linux kernel version will most likely be
different to the kernel version in the container.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@LaszloGombos
Copy link
Collaborator

My plan is to improve https://github.com/dracutdevs/dracut/blob/master/tools/test-github.sh and document the use of https://github.com/dracutdevs/dracut/blob/master/tools/test-github.sh in docs/HACKING.md.

We should probably rename test-github.sh .

We should probably teach test-github.sh to only set KVERSION is needed (e.g. by detecting containerization).

If there is interest for a quick win in the documentation, I do not mind landing this PR as is.

@bdrung WDYT ?

@bdrung
Copy link
Contributor Author

bdrung commented Aug 19, 2023

The test-github.sh is just another layer of indirection: test-github.sh -> test/Makefile -> test/TEST-$x/Makefile -> test/Makfile.testdir -> ./test.sh. Maybe test/Makefile could set KVERSION depending on what is available.

A quick win for the documentation is useful even when you rework test-github.sh tomorrow.

Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@aafeijoo-suse aafeijoo-suse merged commit 23389f6 into dracutdevs:master Aug 24, 2023
82 of 92 checks passed
@bdrung bdrung deleted the kversion branch August 24, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants