Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): use bash for jobs -r parameter #2496

Merged
merged 1 commit into from Aug 22, 2023

Conversation

bdrung
Copy link
Contributor

@bdrung bdrung commented Aug 21, 2023

Changes

Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on Debian with following error message in server.log:

jobs -rp
/sbin/init: 105: jobs: Illegal option -r

The jobs parameter -r requires bash.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Partially fixes #1901

@github-actions github-actions bot added the test Issues related to testing label Aug 21, 2023
@bdrung bdrung changed the title fix(test): fix jobs: Illegal option -r fix(test): use bash for jobs -r parameter Aug 21, 2023
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on Debian with following
error message in `server.log`:

```
jobs -rp
/sbin/init: 105: jobs: Illegal option -r
```

The jobs parameter `-r` requires bash.

Partially fixes dracutdevs#1901
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@bdrung
Copy link
Contributor Author

bdrung commented Aug 21, 2023

Enhanced the commit to also cover TEST-50-MULTINIC which uses jobs -rp as well.

Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aafeijoo-suse aafeijoo-suse merged commit 9a18f13 into dracutdevs:master Aug 22, 2023
101 of 107 checks passed
@bdrung bdrung deleted the test-20-debian branch August 22, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on debian
3 participants