Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(systemd-pcrphase): rename systemd-pcrphase binary to systemd-pcrextend #2526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(systemd-pcrphase): rename systemd-pcrphase binary to systemd-pcrextend #2526

wants to merge 1 commit into from

Conversation

aafeijoo-suse
Copy link
Member

The systemd-pcrphase binary has been renamed to systemd-pcrextend since systemd/systemd@32295fa0

This patch will be necessary for systemd-v255.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@aafeijoo-suse
fix(systemd-pcrphase): rename systemd-pcrphase binary to systemd-pcre…
8d9b558 
…xtend

The `systemd-pcrphase` binary has been renamed to `systemd-pcrextend` since
systemd/systemd@32295fa0
@github-actions github-actions bot added the modules Issue tracker for all modules label Sep 26, 2023
@LaszloGombos LaszloGombos added this to the dracut-061 milestone Nov 1, 2023
@aafeijoo-suse aafeijoo-suse mentioned this pull request Nov 2, 2023
Closed
@aafeijoo-suse aafeijoo-suse removed this from the dracut-061 milestone Nov 18, 2023
@LaszloGombos LaszloGombos mentioned this pull request Dec 10, 2023
Open
@lnykryn
Copy link
Member

lnykryn commented Dec 11, 2023

Wouldn't this break compatibility with older systemd?

@ferringb
Copy link

ferringb commented Dec 12, 2023 •
edited

Wouldn't this break compatibility with older systemd?

yep. #2586 should provide compatibility for both, albeit requiring the dracut invocation to use systemd-pcrextend name

@aafeijoo-suse
Copy link
Member Author

Wouldn't this break compatibility with older systemd?

Yes, systemd-pcrphase was introduced in systemd-v252. I thought that our current upstream policy was to support only the latest version of other upstream dependencies, otherwise this is unmanageable.

LaszloGombos

This comment was marked as duplicate.

Sign in to view

LaszloGombos
LaszloGombos suggested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still on systemd-v252

@stale Stale
Copy link

stale bot commented Mar 13, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Mar 13, 2024
@aafeijoo-suse aafeijoo-suse removed the stale communication is stuck label Mar 14, 2024
@stale Stale
Copy link

stale bot commented Apr 22, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloGombos LaszloGombos LaszloGombos requested changes

@haraldh haraldh Awaiting requested review from haraldh haraldh is a code owner

@johannbg johannbg Awaiting requested review from johannbg johannbg is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
modules Issue tracker for all modules stale communication is stuck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aafeijoo-suse @lnykryn @ferringb @LaszloGombos