Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resume): add new systemd-hibernate-resume.service #2527

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(resume): add new systemd-hibernate-resume.service #2527

wants to merge 1 commit into from

Conversation

aafeijoo-suse
Copy link
Member

Since systemd/systemd@a628d933, the generator only does the initial validation of the system info and then enables the new systemd-hibernate-resume.service.

Not tested, but this patch will be required for systemd-v255 based on #2513 (comment).

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #2513

@aafeijoo-suse
fix(resume): add new systemd-hibernate-resume.service
a2fe891 
Since systemd/systemd@a628d933, the generator only
does the initial validation of the system info and then enables the new
`systemd-hibernate-resume.service`.

Fixes dracutdevs#2513
@github-actions github-actions bot added modules Issue tracker for all modules resume Issues related to the resume module labels Sep 26, 2023
@LaszloGombos LaszloGombos added this to the dracut-061 milestone Oct 31, 2023
@aafeijoo-suse aafeijoo-suse mentioned this pull request Nov 2, 2023
Closed
@aafeijoo-suse aafeijoo-suse removed this from the dracut-061 milestone Nov 18, 2023
@LaszloGombos LaszloGombos mentioned this pull request Dec 12, 2023
Open
@Flowdalic
Copy link

Flowdalic commented Dec 19, 2023 •
edited

I have tested this patch and can confirm that it is required for resume functionality with systemd 255. Please consider merging it soon, since systemd 255 was released recently.

gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Dec 20, 2023
@Flowdalic
sys-kernel/dracut: add patch to fix resume with systemd 255
ef10f91 
Apply the patch from dracutdevs/dracut#2527 to
include the new systemd-hibernate-resume service file of systemd 255 in
the initrd image.

Signed-off-by: Florian Schmaus <flow@gentoo.org>
@MikPisula
Copy link

I have tested this patch as well.

@aafeijoo-suse aafeijoo-suse linked an issue Jan 26, 2024 that may be closed by this pull request
Dracut does not generate images that support hibernation #2587
Open
archlinux-github pushed a commit to archlinux/aur that referenced this pull request Mar 2, 2024
@LaszloGombos
https://github.com/dracutdevs/dracut/pull/2527
93a8640
@stale Stale
Copy link

stale bot commented Mar 13, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Mar 13, 2024
@aafeijoo-suse aafeijoo-suse removed the stale communication is stuck label Mar 14, 2024
@LaszloGombos LaszloGombos mentioned this pull request Mar 30, 2024
Merged
@stale Stale
Copy link

stale bot commented Apr 22, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloGombos LaszloGombos LaszloGombos approved these changes

@haraldh haraldh Awaiting requested review from haraldh haraldh is a code owner

@johannbg johannbg Awaiting requested review from johannbg johannbg is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
modules Issue tracker for all modules resume Issues related to the resume module stale communication is stuck
Projects
None yet
Milestone
No milestone
4 participants
@aafeijoo-suse @Flowdalic @MikPisula @LaszloGombos