[RHEL-8] network-manager updates #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@lkundrak hey, could you please rebase this PR so it uses the fixed Travis config? |
lkundrak
force-pushed
the
RHEL-8/lr/network-manager
branch
from
3d31d21
to
429e83a
Compare
Look for "connection-uuid" instead of "managed" to determine the devices that are actually activated with a connection and call the online hook. This fixes the anaconda-net root mount, which utilizes the online hook. (cherry picked from commit 79a17b0)
(cherry picked from commit 5e0f8c8)
(cherry picked from commit 4be95b6)
If the root is on network, let nm-initrd-generator create configuration even if none was explicitly specified on the command line. Also do the same if /tmp/net.ifaces exists, because the anaconda plugin creates an empty file in that location in hopes that will make us configure the network. (cherry picked from commit 381ab6b)
Move the logic from network-legacy to common network code. (cherry picked from commit 35efada)
The IFCFG test will make sure the network-legacy plugin keeps writing out correct ifcfg files. This is a separate commit so that actual changes are visible in the following one. (cherry picked from commit 70787ab)
If the network-manager plugin is used instead, it wouldn't write out ifcfg files and we wouldn't have anything to check. While at that, also enable the test. (cherry picked from commit 2b1b3bc)
The network-manager module writes keyfiles instead of ifcfg files. Just check whether the configuration got actually applied correctly. (cherry picked from commit 9dfd73b)
…nager The .did-setup files are not there. What is there is the NetworkManager connection files. (cherry picked from commit 393fb1a)
lkundrak
force-pushed
the
RHEL-8/lr/network-manager
branch
from
429e83a
to
3359498
Compare
mrc0mmand
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in the network-manager fixes (along with the test fixes) and and extra change that will make Dracut not switch to network-manager by default when nm-initrd-generator gets updated.