Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the new udevadm version output #842

Merged
merged 1 commit into from Jun 25, 2020
Merged

Conversation

jsynacek
Copy link
Contributor

See https://bugzilla.redhat.com/show_bug.cgi?id=1804252.

RHEL-only

Resolves: #1846034

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@jsynacek
Copy link
Contributor Author

The failed tests seem to be unrelated. The patch is backwards compatible as it simply "clamps" the output of udevadm --version in case it has more than one field.

@haraldh
Copy link
Collaborator

haraldh commented Jun 18, 2020

Instead of cut pure shell can be used.. bin/cut is not even installed

@danimo
Copy link
Contributor

danimo commented Jun 18, 2020

Out of interest: why is this RHEL only?

@lnykryn
Copy link
Member

lnykryn commented Jun 18, 2020

@danimo we patched systemd to contain release:
[root@ci-vm-10-0-138-178 ~]# udevadm --version
239 (239-33.el8)

@jsynacek
Copy link
Contributor Author

Instead of cut pure shell can be used.. bin/cut is not even installed

Well...

$ git grep '\Wcut\W'
dracut-init.sh:    if ! command -v kmod &>/dev/null && vercmp "$(modprobe --version | cut -d' ' -f3)" lt 3.7; then
dracut.sh:        _isize_new=$(du -sk ${initdir}|cut -f1)
modules.d/90kernel-modules-extra/module-setup.sh:		| sort -u -k1,1 -t '/' | cut -f 2- -d '/'))
modules.d/95iscsi/module-setup.sh:    for iface_desc in $(iscsiadm -m iface | cut -f 2 -d ' '); do

@jsynacek
Copy link
Contributor Author

v2.

@haraldh
Copy link
Collaborator

haraldh commented Jun 25, 2020

Instead of cut pure shell can be used.. bin/cut is not even installed

Well...

$ git grep '\Wcut\W'
dracut-init.sh:    if ! command -v kmod &>/dev/null && vercmp "$(modprobe --version | cut -d' ' -f3)" lt 3.7; then
dracut.sh:        _isize_new=$(du -sk ${initdir}|cut -f1)
modules.d/90kernel-modules-extra/module-setup.sh:		| sort -u -k1,1 -t '/' | cut -f 2- -d '/'))
modules.d/95iscsi/module-setup.sh:    for iface_desc in $(iscsiadm -m iface | cut -f 2 -d ' '); do

module-setup.sh is executed while building the initramfs image.

@haraldh
Copy link
Collaborator

haraldh commented Jun 25, 2020

v2.

Perfect, thanks!

@haraldh haraldh merged commit fc05c81 into dracutdevs:RHEL-8 Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants