Fe 10 migrate the contact page #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wazery
requested changes
Jan 21, 2019
app/components/Contact/index.js
Outdated
| }), | ||
| handleSubmit: values => { | ||
| // Handle http request here | ||
| console.log(values); |
There was a problem hiding this comment.
@ZeeshanTamboli I think we have to remove all console statements, I also think if there is something we want to implement later we can add it as a // TODO: implement this feature #16 and we can create an issue for it and add its issue number to the comment.
There was a problem hiding this comment.
Other than that this PR LGTM. 👍
There was a problem hiding this comment.
Yes. Removed console statements and added comment. Created an issue as well. My Circle CI tests are failing. After running tests locally it shows -
Jest: "global" coverage threshold for branches (91%) not met: 83.33%
Jest: "global" coverage threshold for functions (98%) not met: 92.86%
How do I resolve this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Boilerplate
Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure:
devand targetsdevBe kind to code reviewers, please try to keep pull requests as small and focused as possible :)
IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.