Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] Boolean should be compared strictly - in src/Vies/Vies.php, line 189 #12

Closed
DragonBe opened this issue Jun 28, 2015 · 1 comment

Comments

@DragonBe
Copy link
Owner

in src/Vies/Vies.php, line 189

With booleans, only strict comparison (with === operator) should be used to lower bug risks and to improve performances.

     *
     * @return Validator
     */
    public function getValidator()
    {
        if (null == $this->validator) {
            $this->validator = new Validator();
        }

        return $this->validator;
    }

Posted from SensioLabsInsight

@krzaczek
Copy link
Collaborator

fixed in #11

DragonBe added a commit that referenced this issue Jul 1, 2015
@DragonBe DragonBe closed this as completed Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants