Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): add support for nodePort #205

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

mueller-ma
Copy link
Contributor

Closes #204

@mueller-ma
Copy link
Contributor Author

I tried to follow the steps from CONTRIBUTING.md and deployt this version of the operator, but the CRDs didn't change. When I try to apply the following file, I get the error strict decoding error: unknown field "spec.resources.serviceSpec":

apiVersion: dragonflydb.io/v1alpha1
kind: Dragonfly
metadata:
  labels:
    app.kubernetes.io/name: dragonfly
    app.kubernetes.io/instance: dragonfly-sample
    app.kubernetes.io/part-of: dragonfly-operator
    app.kubernetes.io/managed-by: kustomize
    app.kubernetes.io/created-by: dragonfly-operator
  name: dragonfly-sample
spec:
  replicas: 2
  resources:
    requests:
      cpu: 500m
      memory: 500Mi
    limits:
      cpu: 600m
      memory: 750Mi
    serviceSpec:
      type: NodePort
      nodePort: 20001

Did I miss any file that needs to be updated as well? I looked at the PR #187 for this change.

@romange romange requested a review from Abhra303 June 21, 2024 15:22
@Abhra303
Copy link
Contributor

Abhra303 commented Jun 24, 2024

@mueller-ma, you have put serviceSpec under resources. serviceSpec should be at the same level as resources.

Closes dragonflydb#204

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma mueller-ma marked this pull request as ready for review June 27, 2024 08:54
@mueller-ma
Copy link
Contributor Author

Thanks for that hint. With a valid yaml Dragonfly manifest, I was able to deploy a dragonfly instance, that uses a fixed node port.

@Abhra303 Abhra303 merged commit f66bfc4 into dragonflydb:main Jul 1, 2024
2 checks passed
@mueller-ma mueller-ma deleted the nodeport branch July 2, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request a fixed nodeport
2 participants