Skip to content

Commit

Permalink
chore: move RdImpl functions together (#1694)
Browse files Browse the repository at this point in the history
No functional changes are made.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
  • Loading branch information
romange authored and kostasrim committed Aug 14, 2023
1 parent 45b8b65 commit c1f3508
Showing 1 changed file with 50 additions and 50 deletions.
100 changes: 50 additions & 50 deletions src/core/sorted_map.cc
Original file line number Diff line number Diff line change
Expand Up @@ -158,34 +158,6 @@ optional<double> SortedMap::RdImpl::GetScore(sds member) const {
return *(double*)dictGetVal(de);
}

int SortedMap::DfImpl::Add(double score, sds ele, int in_flags, int* out_flags, double* newscore) {
LOG(FATAL) << "TBD";
return 0;
}

optional<double> SortedMap::DfImpl::GetScore(sds ele) const {
LOG(FATAL) << "TBD";
return std::nullopt;
}

void SortedMap::DfImpl::Init() {
LOG(FATAL) << "TBD";
}

void SortedMap::DfImpl::Free() {
LOG(FATAL) << "TBD";
}

bool SortedMap::DfImpl::Insert(double score, sds member) {
LOG(FATAL) << "TBD";
return false;
}

optional<unsigned> SortedMap::DfImpl::GetRank(sds ele, bool reverse) const {
LOG(FATAL) << "TBD";
return std::nullopt;
}

SortedMap::ScoredArray SortedMap::RdImpl::GetRange(const zrangespec& range, unsigned offset,
unsigned limit, bool reverse) const {
/* If reversed, get the last node in range as starting point. */
Expand Down Expand Up @@ -217,12 +189,6 @@ SortedMap::ScoredArray SortedMap::RdImpl::GetRange(const zrangespec& range, unsi
return result;
}

SortedMap::ScoredArray SortedMap::DfImpl::GetRange(const zrangespec& range, unsigned offset,
unsigned limit, bool reverse) const {
LOG(FATAL) << "TBD";
return {};
}

SortedMap::ScoredArray SortedMap::RdImpl::GetLexRange(const zlexrangespec& range, unsigned offset,
unsigned limit, bool reverse) const {
zskiplistNode* ln;
Expand Down Expand Up @@ -259,12 +225,6 @@ SortedMap::ScoredArray SortedMap::RdImpl::GetLexRange(const zlexrangespec& range
return result;
}

SortedMap::ScoredArray SortedMap::DfImpl::GetLexRange(const zlexrangespec& range, unsigned offset,
unsigned limit, bool reverse) const {
LOG(FATAL) << "TBD";
return {};
}

uint8_t* SortedMap::RdImpl::ToListPack() const {
uint8_t* lp = lpNew(0);

Expand All @@ -280,11 +240,6 @@ uint8_t* SortedMap::RdImpl::ToListPack() const {
return lp;
}

uint8_t* SortedMap::DfImpl::ToListPack() const {
LOG(FATAL) << "TBD";
return nullptr;
}

bool SortedMap::RdImpl::Delete(sds member) {
dictEntry* de = dictUnlink(dict, member);
if (de == NULL)
Expand All @@ -309,11 +264,6 @@ bool SortedMap::RdImpl::Delete(sds member) {
return true;
}

bool SortedMap::DfImpl::Delete(sds ele) {
LOG(FATAL) << "TBD";
return false;
}

SortedMap::ScoredArray SortedMap::RdImpl::PopTopScores(unsigned count, bool reverse) {
zskiplistNode* ln;
if (reverse) {
Expand Down Expand Up @@ -406,6 +356,56 @@ bool SortedMap::RdImpl::Iterate(unsigned start_rank, unsigned len, bool reverse,
return success;
}

int SortedMap::DfImpl::Add(double score, sds ele, int in_flags, int* out_flags, double* newscore) {
LOG(FATAL) << "TBD";
return 0;
}

optional<double> SortedMap::DfImpl::GetScore(sds ele) const {
LOG(FATAL) << "TBD";
return std::nullopt;
}

void SortedMap::DfImpl::Init() {
LOG(FATAL) << "TBD";
}

void SortedMap::DfImpl::Free() {
LOG(FATAL) << "TBD";
}

bool SortedMap::DfImpl::Insert(double score, sds member) {
LOG(FATAL) << "TBD";
return false;
}

optional<unsigned> SortedMap::DfImpl::GetRank(sds ele, bool reverse) const {
LOG(FATAL) << "TBD";
return std::nullopt;
}

SortedMap::ScoredArray SortedMap::DfImpl::GetRange(const zrangespec& range, unsigned offset,
unsigned limit, bool reverse) const {
LOG(FATAL) << "TBD";
return {};
}

SortedMap::ScoredArray SortedMap::DfImpl::GetLexRange(const zlexrangespec& range, unsigned offset,
unsigned limit, bool reverse) const {
LOG(FATAL) << "TBD";
return {};
}

uint8_t* SortedMap::DfImpl::ToListPack() const {
LOG(FATAL) << "TBD";
return nullptr;
}

bool SortedMap::DfImpl::Delete(sds ele) {
LOG(FATAL) << "TBD";
return false;
}

SortedMap::ScoredArray SortedMap::DfImpl::PopTopScores(unsigned count, bool reverse) {
LOG(FATAL) << "TBD";
return {};
Expand Down

0 comments on commit c1f3508

Please sign in to comment.