-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker-compose): Add a docker-compose.yml
#100
Comments
Hi Ryan,
It's a great suggestion. I would put docker-compose.yml under contrib/.
tools/docker is for project maintainers to describe how to build docker
imagers so i think it's not the right place for deployment scripts.
Regarding the quickstart - i would put a dedicated markdown file under doc
dir and link it from Readme. What do you think?
…On Sun, Jun 5, 2022, 18:24 Ryan Russell ***@***.***> wrote:
Issue: When I googled to see if there's a ready-made docker-compose.yml I
could plug in, I get a different DragonFly project all together.
This is frustrating to a new user looking for a quick and dirty way to
test in 5 minutes.
[image: image]
<https://user-images.githubusercontent.com/523300/172057695-581a2b0f-7c37-4453-b6bf-3dc6343f608b.png>
Solution: Add a docker-compose.yml and Quick Start guide.
Suggestion: Make sure docker-compose + docker stack deploy Quick Start
guides work. IMO Swarm Mode has quietly become respectable as a
lower-maintenance multi-node scheduler.
@romange <https://github.com/romange> Do you already have a compose file
or opinions on where you want them file-wise(I see your dockerfiles in
tools/docker)?
Or I can stage one if you prefer....
—
Reply to this email directly, view it on GitHub
<#100>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCGFNBXUJBSUDMMP5C3VNTBBZANCNFSM5X5GIHGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sounds good. It's on my todo list for my own uses; give me a couple days to shake it down and I'll post a version for the OSS repo. |
FYI, I will be less responsive today and tomorrow. |
Update: I've read about Git LFs. seems like exactly what we need, don't you think? |
I'd be careful about it. In the past, i had pretty bad experience with Git LFs. To the extent where I had nothing but garbage left. For the beginning I'd simply recommend to not worry about it (but also don't commit 4k sized screenshots into Git) and when (if) it becomes necessary, a migration can still be done. |
But then we would be stuck with already uploaded images, would we? One minor con is that folks that clone the repo will need to install lfs plugin in order to access these files. But usually, people read docs directly from github so I do not see it as huge blocker and contributors will manage. |
Hey @romange -- joined the discord channel so we can discuss ideas quicker/more easily. Need to update the permissions to allow users to send messages in the room. I believe I should just submit the basic yaml and README with no images for now. Git LFS is a permanent decision we don't need(want?) Seems WAY easier to just wait to include images and put images in a non-git-repo location in the future. Will send PR later to keep things moving forward. |
Ok, so 2 people more experienced than me are inclined against Git LFS. cloud bucket it is but I will manage it. |
* feat(docker-compose): Add `docker-compose.yml` #100 Signed-off-by: Ryan Russell <git@ryanrussell.org> * docs(build-from-source): Include build from source Signed-off-by: Ryan Russell <git@ryanrussell.org>
Housekeeping. Re-open if necessary. |
Issue: When I googled to see if there's a ready-made
docker-compose.yml
I could plug in, I get a differentDragonFly
project all together.This is frustrating to a new user looking for a quick and dirty way to test in 5 minutes.
Solution: Add a
docker-compose.yml
andQuick Start
guide.Suggestion: Make sure
docker-compose
+docker stack deploy
Quick Start guides work. IMOSwarm Mode
has quietly become respectable as a lower-maintenance multi-node scheduler.@romange Do you already have a compose file or opinions on where you want them file-wise(I see your dockerfiles in
tools/docker
)?Or I can stage one if you prefer....
The text was updated successfully, but these errors were encountered: