-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replicaof command flag #1381
Comments
Lets make it |
Just have to make sure we parse IPv6 addresses correctly (see https://softwareengineering.stackexchange.com/questions/311413/how-should-we-represent-an-ipv6-address-with-port-number-in-text) |
I can help to implement this task.
|
Ideally I think the both seems needed 👍 |
@talbii Note: we will need to support setting this flag from config set command |
@adiholden it's not clear what's the expected behavior for this. Lets first check internally if it's really required. |
Sounds completely reasonable, also shouldn't be a problem to implement in code. I'll do this tomorrow. Might be a bit problematic since |
* introduce `--replicaof` flag Closes #1381. The behvaiour of `--replicaof` is similar to `REPLICAOF`. On startup, the instance continuously attempts to connect to master. Stop using the normal `REPLICAOF NO ONE` command. The flag expects format `<IPv4/host>:<port>` or `[<IPv6>]:<port>`. --------- Signed-off-by: talbii <ido@dragonflydb.io> Signed-off-by: talbii <41526934+talbii@users.noreply.github.com>
as discussed on slack for starting replication from now we need to interact with the redis protocol to set the master.
for auto starting replication we need something like --slaveof= flag.
(even if some ugly hack with systemd post start is possible)
The text was updated successfully, but these errors were encountered: