Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot_cron can not be changed at runtime #1762

Closed
romange opened this issue Aug 29, 2023 · 1 comment · Fixed by #2101
Closed

snapshot_cron can not be changed at runtime #1762

romange opened this issue Aug 29, 2023 · 1 comment · Fixed by #2101
Assignees
@BorysTheDev
Labels
enhancement New feature or request minor nice to have enhancement

Comments

@romange
Copy link
Collaborator

romange commented Aug 29, 2023

Definition of done: config set snapshot_cron "..." works.

Please note the current code inside ServerFamily::SnapshotScheduling() is currently structured in such way that
it reads the flag only on startup.
@romange romange added enhancement New feature or request minor nice to have enhancement labels Aug 29, 2023
@UkuLoskit UkuLoskit mentioned this issue Sep 28, 2023
Closed
@romange
Copy link
Collaborator Author

romange commented Oct 1, 2023

it's community feature, not needed by our management plane

@BorysTheDev BorysTheDev self-assigned this Oct 30, 2023
BorysTheDev added a commit that referenced this issue Nov 1, 2023
@BorysTheDev
add ability to set snapshot_cron flag during runtime(#1762)
148cd7c
BorysTheDev added a commit that referenced this issue Nov 1, 2023
@BorysTheDev
add ability to set snapshot_cron flag during runtime(#1762)
00e22c4
@romange romange mentioned this issue Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BorysTheDev BorysTheDev

Labels
enhancement New feature or request minor nice to have enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ability to set snapshot_cron flag during runtime(#1762) dragonflydb/dragonfly
2 participants
@romange @BorysTheDev