Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sscan does not work with redisson client #503

Closed
romange opened this issue Nov 21, 2022 · 1 comment
Closed

sscan does not work with redisson client #503

romange opened this issue Nov 21, 2022 · 1 comment
Assignees
@boazsade

Comments

@romange
Copy link
Collaborator

romange commented Nov 21, 2022

Based on discord discussion.
Radisson fails to parse SSCAN response from dragonfly.
The repo that reproduces the problem is here: https://github.com/romange/dragonfly-redisson (forked to ensure it persists).
boazsade added a commit to boazsade/dragonfly that referenced this issue Nov 21, 2022
@boazsade
fix(server): all scan commands needs to return cursor as bulk string d…
287ccdd 
…ragonflydb#503

Signed-off-by: Boaz Sade <boaz@dragonflydb.io>
@boazsade boazsade mentioned this issue Nov 21, 2022
Merged
@boazsade
Copy link
Contributor

This issue is related to the return type for scan/sscan/hscan/zscan all should return bulk string as the type for the cursor value from these commands

boazsade added a commit to boazsade/dragonfly that referenced this issue Nov 21, 2022
@boazsade
fix(server): scan cursor returning bulk string dragonflydb#503
2b5f33a 
Signed-off-by: Boaz Sade <boaz@dragonflydb.io>
romange pushed a commit that referenced this issue Nov 21, 2022
@boazsade
fix(server): all scan commands needs to return cursor as bulk string #…
235ff67 
…503 (#504)

fix(server): scan cursor returning bulk string #503

Signed-off-by: Boaz Sade <boaz@dragonflydb.io>
@romange romange closed this as completed Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boazsade boazsade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romange @boazsade