Dispatch queue backpressure and batching #1118

dranikpg · 2023-04-20T20:49:44Z

This PR:

Adds "almost correct" backpressure to publish messages (without decreasing dispatch performance)
Enables batching for pubsub

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>

src/facade/dragonfly_connection.h

src/server/main_service.cc

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>

dranikpg changed the title ~~[WIP] Dispatch queue backpressure~~ [WIP] Dispatch queue backpressure and batching Apr 20, 2023

dranikpg force-pushed the dsq-bp branch 4 times, most recently from d68baa6 to 5ee9c62 Compare April 22, 2023 07:22

feat: batch all dsq ops

c6660d2

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>

dranikpg force-pushed the dsq-bp branch from 5ee9c62 to c6660d2 Compare April 22, 2023 07:24

dranikpg marked this pull request as ready for review April 22, 2023 07:25

dranikpg changed the title ~~[WIP] Dispatch queue backpressure and batching~~ Dispatch queue backpressure and batching Apr 22, 2023

dranikpg requested a review from romange April 23, 2023 08:03

romange reviewed Apr 23, 2023

View reviewed changes

src/facade/dragonfly_connection.h Outdated Show resolved Hide resolved

romange reviewed Apr 23, 2023

View reviewed changes

src/server/main_service.cc Show resolved Hide resolved

fix: small fixes

d313661

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>

dranikpg requested a review from romange April 24, 2023 06:46

romange approved these changes Apr 26, 2023

View reviewed changes

dranikpg merged commit 432ece3 into dragonflydb:main Apr 28, 2023
6 checks passed

dranikpg deleted the dsq-bp branch April 30, 2023 15:38

Provide feedback