New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): allow AUTH and SETNAME options in the HELLO command #1156

Merged

romange merged 1 commit into dragonflydb:main from rueian:hello-auth

Apr 28, 2023

Contributor

rueian commented Apr 28, 2023 •

edited by romange

I just tried to implement AUTH and SETNAME in the HELLO command to resolve the issue #1151 by copying logic from here https://github.com/redis/redis/blob/d659c734569be4ed32a270bac2527ccf35418c43/src/networking.c#L3529-L3579

#Fixes #1151


          feat(server): allow AUTH and SETNAME options in the HELLO command

c545845

Signed-off-by: Rueian <rueiancsie@gmail.com>

Collaborator

romange commented Apr 28, 2023

@rueian Thank you, this looks good!
Waiting for the tests to run

romange approved these changes

View reviewed changes

romange merged commit 688f8f5 into dragonflydb:main

6 checks passed

rueian mentioned this pull request

[WIP] Update Dragonfly > v1.3.0 redis/rueidis#203

Closed

wacdev mentioned this pull request

no support use hello auth for resp3 #1196

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment