chore: improve xadd performance and remove redundant allocations #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romange
commented
Apr 29, 2023
romange
commented
- Incorporate StreamAppendItem into c++ codebase and stop using t_stream implementation.
- Change its signature to accept CmdArgList instead of array of robj*.
chakaz
previously approved these changes
May 2, 2023
1. Incorporate StreamAppendItem into c++ codebase and stop using t_stream implementation. 2. Change its signature to accept CmdArgList instead of array of robj*. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
|
Fixed punctuation comments. |
chakaz
approved these changes
May 3, 2023
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.