Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was found inside
test_cancel_replication_immediately
of the regression testshttps://github.com/dragonflydb/dragonfly/actions/runs/4828930130/jobs/8603358782
The stacktrace suggests that we try to shut down a socket that is already closed or not initalized. What is more,
indicates that it must be that
Replica::Start
is cancelled after the socket is initialized (the pointer is valid), but before it's connected (fd = -1)I first looked only at the iouring socket's code and saw that fd is not changed even on errors, which made me think of many different causes for this bug. But as pytests are running with epoll, it simply looks like the socket failed to connect, set fd_ to -1 and the contex was cancelled.