Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redis): Add crc16 redis function #1173

Merged
merged 2 commits into from May 2, 2023
Merged

feat(redis): Add crc16 redis function #1173

merged 2 commits into from May 2, 2023

Conversation

adiholden
Copy link
Collaborator

crc16 is needed for cluster slot calculation

Signed-off-by: adi_holden <adi@dragonflydb.io>
@adiholden adiholden requested a review from romange May 2, 2023 08:17
@@ -0,0 +1,8 @@
#ifndef CRC64_H
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRC64_H -> CRC16_H

Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to add to CMakeLists.txt

@adiholden
Copy link
Collaborator Author

you also need to add to CMakeLists.txt

Wops I forgot to add it to this PR

@adiholden adiholden requested a review from romange May 2, 2023 10:53
@romange romange merged commit b480384 into main May 2, 2023
6 checks passed
@romange romange deleted the slots branch May 2, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants