Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERSIST returns 0 when key has no expiry #1178

Merged
merged 1 commit into from May 3, 2023
Merged

PERSIST returns 0 when key has no expiry #1178

merged 1 commit into from May 3, 2023

Conversation

talbii
Copy link
Contributor

@talbii talbii commented May 3, 2023

Closes #846.

@talbii
Return 0 when key has no expiry
fbad8b3 
Signed-off-by: talbii <ido@dragonflydb.io>
@romange
Copy link
Collaborator

romange commented May 3, 2023

is it still draft?

@talbii
Copy link
Contributor Author

talbii commented May 3, 2023

Ready to merge in my end, I don't have anything else to add 🙂

@talbii talbii marked this pull request as ready for review May 3, 2023 12:10
@talbii talbii merged commit e91cb6b into main May 3, 2023
6 checks passed
@romange romange deleted the persist-return-0 branch May 7, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romange romange romange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PERSIST command should return 0 if key does not have an associated timeout
2 participants
@talbii @romange