fix: use redis.asyncio instead of aioredis #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
romange
approved these changes
May 13, 2023
romange
pushed a commit
that referenced
this pull request
Jun 1, 2023
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aioredis is deprecated and recommends to transition to redis-py. New modules like redis search are supported only there
Fixes #1190
There is also some kind of new issue with cluster client disconnects on redis-py 5.4 馃樀 For some reason it's still counted as alive even when the connection pool is closed, so I had to disable connection checks with cluster clients