fix: handle no key commands in slot check #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
chakaz
reviewed
May 14, 2023
| } | ||
| } | ||
| if (cross_slot) { | ||
| (*dfly_cntx)->SendError("-CROSSSLOT Keys in request don't hash to the same slot"); | ||
| return false; | ||
| } | ||
| // Check keys slot is in my ownership | ||
| if (!server_family_.cluster_config()->IsMySlot(keys_slot)) { | ||
| if (keys_slot && !server_family_.cluster_config()->IsMySlot(*keys_slot)) { |
There was a problem hiding this comment.
I'd use keys_slot.has_value(), but definitely your call.
Anyway, thanks for making this change!
chakaz
approved these changes
May 14, 2023
romange
pushed a commit
that referenced
this pull request
Jun 1, 2023
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DF build currently gives this warning:
I first wanted to ignore it, but it seems that slot_id can actually be non initialized. Because even if cid->first_key_pos() > 0, the command itself can have 0 keys if it uses variadic keys. For example: EVAL {script} 0.
(Yes, it seems like we don't have any tests for this part yet)