chore: Add vlog printings every time we switch global state #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
approved these changes
May 13, 2023
src/server/common.cc
Outdated
Comment on lines
326
to
339
| ostream& operator<<(ostream& os, const dfly::GlobalState gs) { | ||
| switch (gs) { | ||
| case dfly::GlobalState::ACTIVE: | ||
| return os << "ACTIVE"; | ||
| case dfly::GlobalState::LOADING: | ||
| return os << "LOADING"; | ||
| case dfly::GlobalState::SAVING: | ||
| return os << "SAVING"; | ||
| case dfly::GlobalState::SHUTTING_DOWN: | ||
| return os << "SHUTTING DOWN"; | ||
| } | ||
|
|
||
| return os; | ||
| } |
There was a problem hiding this comment.
We already have GlobalStateName, its even in this file
dranikpg
previously approved these changes
May 13, 2023
Should help debugging #1204 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
dranikpg
approved these changes
May 13, 2023
romange
added a commit
that referenced
this pull request
Jun 1, 2023
Should help debugging #1204 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help debugging #1204