feat: search json support + client tests #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
force-pushed
the
search-json-tests
branch
from
1b43ca4
to
7f04d63
Compare
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
search-json-tests
branch
from
7f04d63
to
018dda4
Compare
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
commented
May 14, 2023
Comment on lines
+25
to
+29
| struct IndexData { | ||
| enum DataType { HASH, JSON }; | ||
|
|
||
| // Get numeric OBJ_ code | ||
| uint8_t GetObjCode() const; |
There was a problem hiding this comment.
I just didn't want to include redis headers here, so that's why I didn't set enum values
There was a problem hiding this comment.
I think that these types are not even enums in our redis headers anyway :)
chakaz
previously approved these changes
May 15, 2023
src/server/search_family.cc
Outdated
| @@ -121,7 +127,42 @@ struct StringMapAccessor : public BaseAccessor { | |||
| StringMap* hset_; | |||
| }; | |||
|
|
|||
| // Accessor for json values | |||
| struct JsonAccessor : public BaseAccessor { | |||
| JsonAccessor(JsonType* json) : json_{json} { | |||
There was a problem hiding this comment.
Please make this constructor explicit
Comment on lines
+25
to
+29
| struct IndexData { | ||
| enum DataType { HASH, JSON }; | ||
|
|
||
| // Get numeric OBJ_ code | ||
| uint8_t GetObjCode() const; |
There was a problem hiding this comment.
I think that these types are not even enums in our redis headers anyway :)
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
|
@chakaz please re-approve |
chakaz
approved these changes
May 16, 2023
dranikpg
added a commit
to dranikpg/dragonfly
that referenced
this pull request
May 18, 2023
* feat: search json support + client tests Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io> * fix: small fixes Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io> * fix: small fixes Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io> --------- Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
romange
pushed a commit
that referenced
this pull request
Jun 1, 2023
* feat: search json support + client tests Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io> * fix: small fixes Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io> * fix: small fixes Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io> --------- Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds: