feat(cluster): impl slot data delete #1224
Conversation
Signed-off-by: adi_holden <adi@dragonflydb.io>
src/server/db_slice.cc
Outdated
| @@ -495,6 +495,43 @@ bool DbSlice::Del(DbIndex db_ind, PrimeIterator it) { | |||
| return true; | |||
| } | |||
|
|
|||
| void DbSlice::FlushSlotsFb(const absl::flat_hash_set<SlotId>& slot_ids) { | |||
There was a problem hiding this comment.
If flat_hash_set<SlotId> is being passed a lot I recommend introducing an alias
src/server/db_slice.cc
Outdated
| uint64_t next_version = NextVersion(); | ||
|
|
||
| auto del_entry_cb = [&](PrimeTable::iterator it) { | ||
| std::string tmp; |
There was a problem hiding this comment.
pull tmp out of the callback - to reuse it through all the iteration sequence.
src/server/db_slice.cc
Outdated
| mi_heap_collect(ServerState::tlocal()->data_heap(), true); | ||
| } | ||
|
|
||
| void DbSlice::FlushSlots(const SlotSet&& slot_ids) { |
There was a problem hiding this comment.
you do need const I guess
There was a problem hiding this comment.
Yes, a const T&& is something that should not exist.
If you want to take ownership over a parameter, just take it by value (i.e. FlushSlots(SlotSet slot_ids)). That will make it possible to call this function both with rvalues (which will be efficient and will duck an unnecessary copy), or with an lvalue (meaning just a regular variable), which will copy but will not be less efficient than accepting a const T&.
By accepting a T&& argument, you are forcing the caller to pass in a temporary, i.e. this code won't work:
SlotSet slots;
// ...
FlushSlots(slots)So only use that convention to force callers not to copy.
* feat(cluster): impl slot data delete Signed-off-by: adi_holden <adi@dragonflydb.io>
I created FlushSlots function in db_slice. It should be called from DFLY CLUSTER CONFIG command when slots are deleted from node.