Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: S3 writes are now working with new format as well #1252

Merged
merged 1 commit into from
May 22, 2023
Merged

fix: S3 writes are now working with new format as well #1252

merged 1 commit into from
May 22, 2023

Conversation

romange
Copy link
Collaborator

@romange romange commented May 19, 2023

  1. Refactor snapshot saving logic, specifically, build the full path once for both versions.
  2. Pull the newest version of helio, where many s3 bugs are fixed.
  3. Include some cleanups because helio now does not contain Boost.Fibers implementation anymore.

@romange romange requested a review from royjacobson May 19, 2023 04:14
royjacobson
royjacobson approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@royjacobson royjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please -

  1. Rebase (because I accidentally also pulled from helio today)
  2. Check that snapshot_test.py passes

@romange
fix: S3 writes are now working with new format as well
55e55ba 
1. Refactor snapshot saving logic, specifically, build the full
path once for both versions.
2. Pull the newest version of helio, where many s3 bugs are fixed.
3. Include some cleanups because helio now does not contain Boost.Fibers implementation anymore.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@romange romange merged commit 74b3312 into main May 22, 2023
6 checks passed
@romange romange deleted the S3Fix branch May 22, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royjacobson royjacobson royjacobson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romange @royjacobson