feat(community): Add Conventional Commits; Code of Conduct #107 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Russell <git@ryanrussell.org>
Signed-off-by: Ryan Russell <git@ryanrussell.org>
ryanrussell
changed the title
ryanrussell
changed the title
romange
reviewed
Jun 11, 2022
romange
reviewed
Jun 11, 2022
| @@ -0,0 +1,71 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
There was a problem hiding this comment.
was this code taken from somewhere? I saw you modified it to fit DragonflyDb but I wonder if it makes sense to reference here the origin .
There was a problem hiding this comment.
This code was pulled this from one of my repo's I have not opened sourced yet...
"Inspired from" sources would be:
https://github.com/compilerla/conventional-pre-commit
https://gist.github.com/qoomon/5dfcdf8eec66a051ecd85625518cfd13
Not sure if this merits linking ... seems distinct enough to me; can add references if you like...
romange
reviewed
Jun 11, 2022
…cripts` #107 Signed-off-by: Ryan Russell <git@ryanrussell.org>
romange
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Russell git@ryanrussell.org