feat: Support unicode strings in search #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
force-pushed
the
search-unicode
branch
from
2e42600
to
97c1e31
Compare
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
search-unicode
branch
from
97c1e31
to
1ab792f
Compare
|
Looks good! |
royjacobson
previously approved these changes
Aug 14, 2023
kostasrim
previously approved these changes
Aug 15, 2023
| Run({"hset", "d:1", "title", "Веселая СТРЕКОЗА Иван", "visits", "400"}); | ||
| Run({"hset", "d:2", "title", "Die fröhliche Libelle Günther", "visits", "300"}); | ||
| Run({"hset", "d:3", "title", "השפירית המהירה יעקב", "visits", "200"}); | ||
| Run({"hset", "d:4", "title", "πανίσχυρη ΛΙΒΕΛΛΟΎΛΗ Δίας", "visits", "100"}); |
There was a problem hiding this comment.
Greek! Means strong dragonfly zeus 🤣 did you google translate this? (loved ALL the easter egg 👀 )
There was a problem hiding this comment.
Yes, I was just mixing adjective + dragonfly + some stereotypical name 🙂 Sounds like children stories
| EXPECT_EQ(Run({"ft.create", "i1", "schema", "title", "text", "visits", "numeric"}), "OK"); | ||
|
|
||
| // Explicitly using screaming uppercase to check utf-8 to lowercase functionality | ||
| Run({"hset", "d:1", "title", "Веселая СТРЕКОЗА Иван", "visits", "400"}); |
There was a problem hiding this comment.
"Merry DRAGONFLY Ivan" 🤣
Signed-off-by: Vladislav <vlad@dragonflydb.io>
kostasrim
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for unicode strings in search. Those are now split by word boundaries with the ICU library, so unicode sentences should be handled correctly. Added tests with simple sentences in four languages
Adds a dependency on libicu-dev