chore: clean up save #1709
chore: clean up save #1709
Conversation
dranikpg
force-pushed
the
refactor-save
branch
from
5393469
to
1664d6a
Compare
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
refactor-save
branch
from
1664d6a
to
75651dd
Compare
|
@kostasrim Please take a brief look, I might proceed with some more changes. Some clarity comments might be missing |
You mean in this PR? |
src/server/server_family.cc
Outdated
| if (!is_cloud_) | ||
| full_path_ += ".tmp"; |
There was a problem hiding this comment.
I changed it to add the .tmp suffix only if its not saved on cloud. Previously it was added in any case, yet snapshots are not renamed for the cloud env. I assume this was a bug
| @@ -522,6 +516,247 @@ bool IsReplicatingNoOne(string_view host, string_view port) { | |||
| return absl::EqualsIgnoreCase(host, "no") && absl::EqualsIgnoreCase(port, "one"); | |||
| } | |||
|
|
|||
| struct SaveStagesInputs { | |||
There was a problem hiding this comment.
according to the stylieguide, consider make it a class and declare variables as protected (they have underscores).
There was a problem hiding this comment.
I moved this out to a separate struct only to use aggregate initialization, its not possible with private/protected members. Alternatively I can just move the fields back and make a separate gigantic contructor that accepts them all
There was a problem hiding this comment.
Ok, how about the option of making the fields public (without underscores) and make this struct a data member instead of an inheritance?
There was a problem hiding this comment.
will open a separate fix on this 😬
no :) |
|
lgtm |
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
refactor-save
branch
from
d8de3ba
to
f771b35
Compare
The current
DoSave()became a 200+ loc monster that is not only difficult to extend but also to read. I noticed this when I wanted to extend it for search serialization.Should not include any functional changes