docs: add snapshot_cron flag in README (English and zh-CN)
#1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niennienzz
force-pushed
the
joezhou/doc-snapshot-cron
branch
from
8721485
to
f2e0285
Compare
|
@Niennienzz there are some whitespace problems |
Niennienzz
force-pushed
the
joezhou/doc-snapshot-cron
branch
2 times, most recently
from
4026ec5
to
903f654
Compare
Thank you @romange, fixed! I think the only CI failing is because of timeout? |
romange
reviewed
Aug 25, 2023
| @@ -106,7 +106,8 @@ There are also some Dragonfly-specific arguments: | |||
| * `dbnum`: Maximum number of supported databases for `select`. | |||
| * `cache_mode`: See the [novel cache design](#novel-cache-design) section below. | |||
| * `hz`: Key expiry evaluation frequency (`default: 100`). Lower frequency uses less CPU when idle at the expense of a slower eviction rate. | |||
| * `save_schedule`: Glob spec for the UTC to save a snapshot in HH:MM (24h time) format (`default: ""`). | |||
| * `snapshot_cron`: Cron schedule expression for automatic backup snapshots using standard cron syntax with the granularity of minutes (`default: ""`). | |||
There was a problem hiding this comment.
it's not straightforward so I think it's a great place to add some examples with the explanation.
There was a problem hiding this comment.
Added examples, linked to our "Saving Backups" doc. 😃
Niennienzz
force-pushed
the
joezhou/doc-snapshot-cron
branch
2 times, most recently
from
9de7e55
to
e625e1f
Compare
romange
reviewed
Aug 26, 2023
README.md
Outdated
| |---------------------------|------------------------------------------------| | ||
| | `* * * * *` | At every minute | | ||
| | `*/5 * * * *` | At every 5th minute | | ||
| | `*/30 * * * *` | At every 30th minute | |
There was a problem hiding this comment.
Thanks, let's remove lines 116, 120, 117 :)
docs: fix whitespaces in kr docs: snapshot_cron examples docs: snapshot_cron less examples
Niennienzz
force-pushed
the
joezhou/doc-snapshot-cron
branch
from
e625e1f
to
6dde76c
Compare
romange
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snapshot_cronflag inREADME.mdandREADME.zh-CN.md.README.zh-CN.md.Memcachedis mis-spelled asMemcache. Fixed in all languages.