fix: fix index loading #1742
Merged
fix: fix index loading #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
kostasrim
previously approved these changes
Aug 25, 2023
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com> Signed-off-by: Vladislav <vladislav.oleshko@gmail.com> Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
fix-index-persistence
branch
from
d5f665b
to
efdb2a5
Compare
kostasrim
approved these changes
Aug 25, 2023
kostasrim
added a commit
that referenced
this pull request
Aug 29, 2023
* fix: fix index loading Signed-off-by: Vladislav <vladislav.oleshko@gmail.com> Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now indices are built separately after they've been read.
Instead of splitting the Init/Rebuild steps, they could've been collected as strings and build fully after loading. But it would've made the dfs loading / search code more complex. Now they're created & validated & stored, but not populated with documents.
Either way we'll need some kind of post-load controller. Alternatively we store the index definitions in all shards and all loading steps are fully independent
Index construction will be async at some point either way, so it will be enough just to notify the "async index creator" after loading that it can run
For now I hope this fix suffices 馃憖