chore: move rdb save related logic into auxillary file #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romange
commented
Aug 30, 2023
•
romange
commented
- No logic was changed during refactoring.
- Flipped the flag to run regression tests for now own with zset_tree=on
1. No logic was changed during refactoring. 2. Flipped the flag to run regression tests for now own with zset_tree=on Signed-off-by: Roman Gershman <roman@dragonflydb.io>
royjacobson
reviewed
Aug 30, 2023
| @@ -72,7 +72,7 @@ def stop(self, kill=False): | |||
| def _start(self): | |||
| if self.params.existing_port: | |||
| return | |||
| base_args = [f"--{v}" for v in self.params.args] | |||
| base_args = ["--use_zset_tree"] + [f"--{v}" for v in self.params.args] | |||
There was a problem hiding this comment.
is this intentionally here?
There was a problem hiding this comment.
yeah, updated the PR description (too lazy to send a commit only for this)
kostasrim
approved these changes
Aug 30, 2023
royjacobson
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.