feat(AclFamily): add acl whoami command #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kostasrim
commented
Aug 30, 2023
kostasrim
commented
- add acl whoami
- add tests
dranikpg
previously approved these changes
Aug 30, 2023
Comment on lines
+227
to
+283
| @pytest.mark.asyncio | ||
| async def test_acl_whoami(async_client): | ||
| await async_client.execute_command("ACL SETUSER kostas >kk +@ALL ON") | ||
|
|
||
| with pytest.raises(redis.exceptions.ResponseError): | ||
| await async_client.execute_command("ACL WHOAMI WHO") | ||
|
|
||
| result = await async_client.execute_command("ACL WHOAMI") | ||
| assert result == "User is default" | ||
|
|
||
| result = await async_client.execute_command("AUTH kostas kk") | ||
|
|
||
| result = await async_client.execute_command("ACL WHOAMI") | ||
| assert result == "User is kostas" |
There was a problem hiding this comment.
Please stop using pytests 😆
There was a problem hiding this comment.
I agree. This type of logic we test with unit tests
There was a problem hiding this comment.
I promise I will move these to units next week after the release ❤️
kostasrim
force-pushed
the
acl_part_8_add_whoami
branch
from
db96c72
to
828ce19
Compare
kostasrim
commented
Sep 1, 2023
| @@ -220,7 +218,7 @@ async def test_acl_deluser(df_server): | |||
|
|
|||
|
|
|||
| script = """ | |||
| for i = 1, 10000 do | |||
| for i = 1, 100000 do | |||
There was a problem hiding this comment.
I slightly increased this to avoid flakes but what I run locally won't necessary reflect the gh runners since the machines we are running on the regressions tests are far more powerful than mine
There was a problem hiding this comment.
They're less powerful. The flakes I was worried about is that it setuser migth run to quickly
dranikpg
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.