feat(json): support JSON.GET pretty print options #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iko1
force-pushed
the
feature/add-opt-param-json-get
branch
from
0b39d0a
to
25f25d4
Compare
iko1
force-pushed
the
feature/add-opt-param-json-get
branch
from
25f25d4
to
e5852d6
Compare
Signed-off-by: iko1 <me@remotecpp.dev>
iko1
force-pushed
the
feature/add-opt-param-json-get
branch
2 times, most recently
from
c5a8076
to
1342e3d
Compare
|
@romange, there is a way to exclude the patch file in this commit from the clang-format validator? |
Signed-off-by: iko1 <me@remotecpp.dev>
iko1
force-pushed
the
feature/add-opt-param-json-get
branch
from
1342e3d
to
005acf5
Compare
|
Hey @iko1 thanks for fixing this issue! Yes, you can check |
romange
reviewed
Sep 18, 2023
src/server/json_family_test.cc
Outdated
| @@ -110,7 +110,9 @@ TEST_F(JsonFamilyTest, SetGetFromPhonebook) { | |||
| EXPECT_EQ(resp, R"(["New York","NY","21 2nd Street","10021-3100"])"); | |||
|
|
|||
| resp = Run({"JSON.GET", "json", "$.firstName", "$.age", "$.lastName"}); | |||
| EXPECT_EQ(resp, R"({"$.age":[27],"$.firstName":["John"],"$.lastName":["Smith"]})"); | |||
| EXPECT_EQ( | |||
There was a problem hiding this comment.
could you please add few tests covering those cases?
There was a problem hiding this comment.
I reverted the change that affected the "JSON.GET" command when formatting args are not supplied with it.
Can you elaborate on which tests are currently missing?
There was a problem hiding this comment.
I added a few tests based on the previous JSON.GET cases that cover the feature functionality.
Signed-off-by: iko1 <me@remotecpp.dev>
iko1
force-pushed
the
feature/add-opt-param-json-get
branch
from
edb065e
to
22f65da
Compare
Signed-off-by: iko1 <me@remotecpp.dev>
iko1
force-pushed
the
feature/add-opt-param-json-get
branch
2 times, most recently
from
f1a63d0
to
64e93bb
Compare
Signed-off-by: iko1 <me@remotecpp.dev>
iko1
force-pushed
the
feature/add-opt-param-json-get
branch
from
64e93bb
to
123cc97
Compare
Signed-off-by: iko1 <me@remotecpp.dev>
romange
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #848