fix(tls): User friendly logging of OpenSSL errors #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
reviewed
Sep 13, 2023
src/server/protocol_client.cc
Outdated
| @@ -51,18 +53,35 @@ using absl::StrCat; | |||
| namespace { | |||
|
|
|||
| #ifdef DFLY_USE_SSL | |||
|
|
|||
| void PrintSSLError() { | |||
There was a problem hiding this comment.
You implemented this and the SSL_CHECK macro twice. Maybe to avoid duplication you can move that in a header sslerror.h (or any other name) ?
kostasrim
previously approved these changes
Sep 13, 2023
kostasrim
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1588
cc @Abhra303