feat(AclFamily): add acl dryrun command #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
Sep 19, 2023
| } | ||
|
|
||
| ToUpper(&args[1]); | ||
| auto command = facade::ArgS(args, 1); |
There was a problem hiding this comment.
@dranikpg just for you ❤️
P.s. I got mixed feelings about this 🤣
There was a problem hiding this comment.
usually its in the dfly namespace, just grep ArgS and you'll see every command uses it
dranikpg
approved these changes
Sep 19, 2023
| } | ||
|
|
||
| ToUpper(&args[1]); | ||
| auto command = facade::ArgS(args, 1); |
There was a problem hiding this comment.
usually its in the dfly namespace, just grep ArgS and you'll see every command uses it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to omit the optional
ARGSbecause it does not make sense in the context of ACL, simply put,ACL DRYRUNasserts that a given command is allowed to be executed by the user. Therefore, if the command itself is illformed, is something beyond the scope ofACL DRYRUN(plus it would be really hard for us to check given our implementation).resolves: #1895