chore: remove redundant Find calls when inserting into DenseSet #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regular DenseSet insertion first checks for uniqueness and then inserts a new element. Sometimes we know that the new element is new and we can insert it without checking for uniqueness first. Also, pass hashcode into internal functions so we could save some hash calls. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
dranikpg
approved these changes
Sep 22, 2023
Comment on lines
-438
to
+442
| auto [newk, added] = score_map->AddOrUpdate(string_view{ele, sdslen(ele)}, score); | ||
| DCHECK(added); | ||
| obj = score_map->AddUnique(string_view{ele, sdslen(ele)}, score); | ||
|
|
||
| *out_flags = ZADD_OUT_ADDED; | ||
| *newscore = score; | ||
| obj = newk; | ||
| added = score_tree->Insert(obj); | ||
| bool added = score_tree->Insert(obj); |
There was a problem hiding this comment.
So that's the only external use so far? I also assume we can use this when we created the key for regular hashes (small nit)
There was a problem hiding this comment.
you can see that also reimplemented StringMap::AddOrSkip that also benefits from this function.
I agree that AddOrUpdate functions should disappear from the interface because they will always be inefficient.
There was a problem hiding this comment.
hmm, actually it's not easy to remove AddOrUpdate because of technical reasons of how entries are created in DenseSet. Will keep thinking about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regular DenseSet insertion first checks for uniqueness and then inserts a new element. Sometimes we know that the new element is new and we can insert it without checking for uniqueness first.
Also, pass hashcode into internal functions so we could save some hash calls.