New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Small refactor of DflyInstance #1951

Merged

royjacobson merged 1 commit into main from instance_new_file_

Sep 28, 2023

Contributor

royjacobson commented Sep 27, 2023

Move to its own file
Unify self.args and self.params.args earlier so it can be inspected. (Solves the problem with --df port=XXX @dranikpg complained about)


          chore: Small refactor of DflyInstance

b0c2478

* Move to its own file
* Unify self.args and self.params.args earlier so it can be inspected.

royjacobson requested a review from dranikpg

September 27, 2023 12:52

dranikpg approved these changes

View reviewed changes

Contributor

dranikpg left a comment

👍🏻

royjacobson merged commit 5c9c925 into main

10 checks passed

royjacobson deleted the instance_new_file_ branch

September 28, 2023 07:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment