fix: fix queue backpressure access #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
romange
reviewed
Oct 7, 2023
src/facade/dragonfly_connection.cc
Outdated
| queue_backpressure_ = &tl_queue_backpressure_; | ||
| if (queue_backpressure_->limit == 0) { | ||
| } | ||
| queue_backpressure_->limit = absl::GetFlag(FLAGS_pipeline_queue_limit); |
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
kostasrim
approved these changes
Oct 7, 2023
| if (queue_backpressure_.limit == 0) | ||
| queue_backpressure_.limit = absl::GetFlag(FLAGS_pipeline_queue_limit); | ||
| queue_backpressure_ = &tl_queue_backpressure_; | ||
| if (queue_backpressure_->limit == 0) { |
There was a problem hiding this comment.
dead if :)
Yeah that was a demonstration of my quick auto-replace capabilities 馃ぃ
|
I tested it locally, I can run it on my fork. But we'll see on the main pipeline either way if it works or not (I mean it should) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a very silly bug in my last PR, the pytests catched it馃槶 In EnusreAsyncMemoryBudget I was calculating the budget not for the intended dispatch thread, but the current one by accessing the thread_local queue limits struct
Instead, we need to access the owning thread's queue memory stats