feat(aws): s3 snapshot error handling #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
previously approved these changes
Oct 10, 2023
andydunstall
force-pushed
the
feature/aws-s3-snapshot-fixes
branch
from
e342412
to
f718529
Compare
dranikpg
approved these changes
Oct 10, 2023
|
Merging (agreed with roman its ok to get this in before release) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements to AWS error handling and logging:
Allow directory with no path
We should support
--dir=s3://mybucketeven though it doesn't have a path.Logging and Error Handling
Improves the error handling and logging of the S3 client since some errors are hard to understand currently
Helio
Depends on romange/helio#154