fix(memcached): parsing multi key get command #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
Nov 3, 2023
romange
reviewed
Nov 3, 2023
src/facade/memcache_parser.cc
Outdated
| s = cur + 1; | ||
| } | ||
| } | ||
| absl::InlinedVector<std::string_view, 32> tokens = absl::StrSplit(tokens_expression, ' '); |
There was a problem hiding this comment.
absl::StrSplit will always allocate a vector.
There was a problem hiding this comment.
you mean a std::vector ? That means that an InlinedVector is implicitly converted to std::vector ?
romange
previously approved these changes
Nov 3, 2023
romange
reviewed
Nov 3, 2023
src/facade/memcache_parser_test.cc
Outdated
| TEST_F(MCParserNoreplyTest, LargeGetRequest) { | ||
| std::string large_request = "get"; | ||
| for (size_t i = 0; i < 100; ++i) { | ||
| absl::StrAppend(&large_request, " mykey", i, ","); |
There was a problem hiding this comment.
why do you put a comma here?
romange
reviewed
Nov 3, 2023
| } | ||
| large_request.pop_back(); | ||
| absl::StrAppend(&large_request, "\r\n"); | ||
| RunTest(large_request, false); |
There was a problem hiding this comment.
you can actually verify what are the keys that are parsed into cmd_
romange
reviewed
Nov 3, 2023
| } | ||
| large_request.pop_back(); | ||
| absl::StrAppend(&large_request, "\r\n"); | ||
| RunTest(large_request, false); |
There was a problem hiding this comment.
you can actually verify what are the keys that are parsed into cmd_
romange
approved these changes
Nov 6, 2023
romange
pushed a commit
that referenced
this pull request
Nov 6, 2023
* remove limit of 8 keys per command * refactor (small) of the parsing logic * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #2121