fix(connection): Fix pipelined command counter #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dranikpg
commented
Nov 22, 2023
dranikpg
commented
- Pipelined command counter is increased even if SendAsync ignores it afterwards
- Add break after yield in connection close
- Add more debug info on check fail
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
fix-squashing-2
branch
from
871446b
to
934b142
Compare
adiholden
reviewed
Nov 22, 2023
| bool threshold_reached = dispatch_q_cmds_count_ > squashing_threshold; | ||
| bool are_all_plain_cmds = dispatch_q_cmds_count_ == dispatch_q_.size(); | ||
| bool threshold_reached = pending_pipeline_cmd_cnt_ > squashing_threshold; | ||
| bool are_all_plain_cmds = pending_pipeline_cmd_cnt_ == dispatch_q_.size(); |
There was a problem hiding this comment.
what are monitor messages? are they PipelineMsg?
There was a problem hiding this comment.
No, they have their own type MonitorMessage. Btw pending_pipeline_cmd_cnt_ was Romans suggestion 😆 I also think it's okay given it has a comment
adiholden
reviewed
Nov 22, 2023
adiholden
approved these changes
Nov 22, 2023
kostasrim
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.