fix(squashing): Reset base command id #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dranikpg can you explain the bug? |
dranikpg
force-pushed
the
fix-squashing-2
branch
from
1e2978b
to
c254270
Compare
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
fix-squashing-2
branch
from
c254270
to
436d506
Compare
|
Fixed. It has the same stacktrace and cause as #2194, but I don't think it's really it. Simply because it's caused only by a specific command sequence |
adiholden
approved these changes
Nov 26, 2023
romange
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi command squasher takes it's base command id (EXEC or EVAL or EVALSHA) from the context. Then the context is modified to run different commands on it. Whenever collection is interrupted inside pipeline squashing due to a nested multi-transaction, we don't reset the base command when we continue using the context.