fix: memcached VERSION is now parseable by php-memcached client #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakaz
reviewed
Nov 27, 2023
src/server/main_service.cc
Outdated
| @@ -1341,7 +1341,7 @@ void Service::DispatchMC(const MemcacheParser::Command& cmd, std::string_view va | |||
| server_family_.StatsMC(cmd.key, cntx); | |||
| return; | |||
| case MemcacheParser::VERSION: | |||
| mc_builder->SendSimpleString(StrCat("VERSION ", kGitTag)); | |||
| mc_builder->SendSimpleString(StrCat("VERSION 1.5.0 DF")); | |||
There was a problem hiding this comment.
No need for StrCat() anymore :)
chakaz
previously approved these changes
Nov 27, 2023
|
nope, it uses |
chakaz
previously approved these changes
Nov 27, 2023
The DF version is being unparseable by Memcached::getVersion() that expects n.n.n string. Change the version to emulate the old memcached server. The DF version can still be fetched via Memcached::getStats() function. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
kostasrim
approved these changes
Nov 27, 2023
| def test_version(memcached_connection: pymemcache.Client): | ||
| """ | ||
| php-memcached client expects version to be in the format of "n.n.n", | ||
| so we return 1.5.0 emulating an old memcached server. Our real version is being returned in the stats command. Also verified manually that php client parses correctly the version string |
There was a problem hiding this comment.
My only concern here is that are you sure that this mocked version 1.5.0 is not used internally by the php client?
What if the php client, uses this version to make some internal decision of some sort?
There was a problem hiding this comment.
I checked the code and I have not seen anything of that kind. Also I succeeded to run the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DF version is being unparseable by Memcached::getVersion() that expects n.n.n string. Change the version to emulate the old memcached server. The DF version can still be fetched via Memcached::getStats() function.