fix(server): initialize replica acked lsn #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <adi@dragonflydb.io>
chakaz
reviewed
Nov 30, 2023
| @@ -46,7 +46,7 @@ struct FlowInfo { | |||
| DflyVersion version; | |||
|
|
|||
| std::optional<LSN> start_partial_sync_at; | |||
| uint64_t last_acked_lsn; | |||
| uint64_t last_acked_lsn = 0; | |||
There was a problem hiding this comment.
If it's possible to use this class before initialization, shouldn't we also initialize conn and version?
There was a problem hiding this comment.
The version and the connection are initialized when the flow is actually created. The last_acked_lsn is set on the first ACK we get from the replica flow.
But yes we can initialize them anyway
kostasrim
previously approved these changes
Nov 30, 2023
chakaz
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2235