New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): Small improvements #2248

Merged

dranikpg merged 1 commit into dragonflydb:main from dranikpg:fix-search

Dec 3, 2023

Contributor

dranikpg commented Dec 2, 2023

Return error for ft.create if index exists
Add configurable M parameter to hnsw (we can't easily support eps / ef)

CC: @Niennienzz


          fix(search): Small improvements

9dc72ac

dranikpg requested a review from chakaz

December 2, 2023 16:49

chakaz approved these changes

View reviewed changes

src/server/search/search_family.cc

+                    },
+                    false);
+                DCHECK(exists_cnt == 0u || exists_cnt == shard_set->size());

Collaborator

chakaz Dec 3, 2023

Not that it matters greatly, but since it's supposed to either be 0 of shard_set->size(), you could do it in a single hop, no?

dranikpg merged commit f17bfaf into dragonflydb:main

7 checks passed

dranikpg deleted the fix-search branch

December 25, 2023 14:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment