chore: Introduce LockKey for LockTable #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
Pr1
branch
2 times, most recently
from
d0f286e
to
459f913
Compare
kostasrim
reviewed
Jan 24, 2024
dranikpg
reviewed
Jan 24, 2024
dranikpg
previously approved these changes
Jan 24, 2024
dranikpg
force-pushed
the
Pr1
branch
3 times, most recently
from
489dcc2
to
701d04e
Compare
|
@romange PTAL. I can't request a review because it's your PR |
|
@dranikpg and I can not approve because it's my PR 👯♂️ . Once it passes tests, please approve and I will submit 😆 |
This should reduce allocations in a common case (not multi). In addition, rename Transaction::args_ to kv_args_. Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
approved these changes
Jan 28, 2024
Comment on lines
+92
to
+99
|
|
||
| auto begin() const { | ||
| return locks_.cbegin(); | ||
| } | ||
|
|
||
| auto end() const { | ||
| return locks_.cbegin(); | ||
| } |
There was a problem hiding this comment.
Actually interesting how this leaks a private type but the compiler doesn't complain 🤷🏻♂️
There was a problem hiding this comment.
apparently it's a language feature
romange
commented
Jan 28, 2024
| auto s = KeyLockArgs::GetLockKey(lock_args.args[i]); | ||
| auto it = lt.find(s); | ||
| if (it != lt.end() && !it->second.Check(mode)) { | ||
| string_view s = KeyLockArgs::GetLockKey(lock_args.args[i]); |
There was a problem hiding this comment.
CheckLock is used now only for debug/testing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce allocations in a common case (not multi). In addition, rename Transaction::args_ to kv_args_.