fix: resolves the crash with MGET and duplicate keys #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2465 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
chakaz
approved these changes
Jan 25, 2024
Comment on lines
+532
to
+537
| string key_arr; | ||
| for (unsigned j = 0; j < keys.size(); ++j) { | ||
| absl::StrAppend(&key_arr, keys[j], ","); | ||
| } | ||
| key_arr.pop_back(); | ||
| LOG(WARNING) << "The keys requested are: [" << key_arr << "]"; |
There was a problem hiding this comment.
Suggested change
| string key_arr; | |
| for (unsigned j = 0; j < keys.size(); ++j) { | |
| absl::StrAppend(&key_arr, keys[j], ","); | |
| } | |
| key_arr.pop_back(); | |
| LOG(WARNING) << "The keys requested are: [" << key_arr << "]"; | |
| LOG(WARNING) << "The keys requested are: [" << absl::StrJoin(keys, ',') << "]"; |
| // bump up the key again, and the first iterator will be invalidated. | ||
| // TODO: to understand better the dynamics of this scenario and to fix it. | ||
| if (it->first != keys[i]) { | ||
| LOG(WARNING) << "Inconcistent key(" << i << "), expected " << keys[i] << " but found " |
There was a problem hiding this comment.
Suggested change
| LOG(WARNING) << "Inconcistent key(" << i << "), expected " << keys[i] << " but found " | |
| LOG(WARNING) << "Inconsistent key(" << i << "), expected " << keys[i] << " but found " |
romange
added a commit
that referenced
this pull request
Jan 25, 2024
Fixes #2465 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
adiholden
added a commit
that referenced
this pull request
Jan 25, 2024
This reverts commit f69f2ec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2465