chore: switch json object to pmr allocator #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romange
commented
Jan 26, 2024
romange
commented
- Move json object creation code to the shard-thread inside rdb_load
- Now json_family never references "json" type, always dfly::JsonType
- Switch JsonType to pmr::json.
- Make sure we pass the correct memory_resource when creating json object from string.
1. Move json object creation code to the shard-thread inside rdb_load 2. Now json_family never references "json" type, always dfly::JsonType 3. Switch JsonType to pmr::json. 4. Make sure we pass the correct memory_resource when creating json object from string. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
dranikpg
previously approved these changes
Jan 26, 2024
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
dranikpg
approved these changes
Jan 26, 2024
romange
added a commit
that referenced
this pull request
Feb 4, 2024
* chore: switch json object to pmr allocator 1. Move json object creation code to the shard-thread inside rdb_load 2. Now json_family never references "json" type, always dfly::JsonType 3. Switch JsonType to pmr::json. 4. Make sure we pass the correct memory_resource when creating json object from string. Signed-off-by: Roman Gershman <roman@dragonflydb.io> --------- Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.